Skip to content

HDFS-17405. [FGL] Using different metric name to trace performance for FGL and Global lock#6600

Merged
ferhui merged 1 commit intoapache:HDFS-17384from
ZanderXu:HDFS-17405
Mar 6, 2024
Merged

HDFS-17405. [FGL] Using different metric name to trace performance for FGL and Global lock#6600
ferhui merged 1 commit intoapache:HDFS-17384from
ZanderXu:HDFS-17405

Conversation

@ZanderXu
Copy link
Contributor

@ZanderXu ZanderXu commented Feb 29, 2024

HDFS-17405. [FGL] Using different metric name to trace performance for FGL and Global lock

@xleoken
Copy link
Member

xleoken commented Feb 29, 2024

hi @ZanderXu, take a review when free, thanks #6591

@ZanderXu ZanderXu requested a review from ferhui March 6, 2024 02:14
ferhui
ferhui approved these changes Mar 6, 2024
View reviewed changes
Copy link
Contributor

@ferhui ferhui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@hadoop-yetus
Copy link

hadoop-yetus commented Mar 6, 2024

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 7m 16s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 test4tests 0m 0s The patch appears to include 1 new or modified test files.
_ HDFS-17384 Compile Tests _
+1 💚 mvninstall 33m 4s HDFS-17384 passed
+1 💚 compile 0m 44s HDFS-17384 passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1
+1 💚 compile 0m 43s HDFS-17384 passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08
+1 💚 checkstyle 0m 38s HDFS-17384 passed
+1 💚 mvnsite 0m 44s HDFS-17384 passed
+1 💚 javadoc 0m 43s HDFS-17384 passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1
+1 💚 javadoc 1m 8s HDFS-17384 passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08
+1 💚 spotbugs 1m 48s HDFS-17384 passed
+1 💚 shadedclient 20m 31s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 💚 mvninstall 0m 37s the patch passed
+1 💚 compile 0m 36s the patch passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1
+1 💚 javac 0m 36s the patch passed
+1 💚 compile 0m 32s the patch passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08
+1 💚 javac 0m 32s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 checkstyle 0m 30s the patch passed
+1 💚 mvnsite 0m 38s the patch passed
+1 💚 javadoc 0m 31s the patch passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1
+1 💚 javadoc 1m 2s the patch passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08
+1 💚 spotbugs 1m 42s the patch passed
+1 💚 shadedclient 20m 22s patch has no errors when building and testing our client artifacts.
_ Other Tests _
-1 ❌ unit 199m 35s /patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt hadoop-hdfs in the patch passed.
+1 💚 asflicense 0m 31s The patch does not generate ASF License warnings.
295m 15s
Reason Tests
Failed junit tests hadoop.hdfs.protocol.TestBlockListAsLongs
hadoop.hdfs.tools.TestDFSAdmin
hadoop.hdfs.server.datanode.TestLargeBlockReport
Subsystem Report/Notes
Docker ClientAPI=1.44 ServerAPI=1.44 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6600/2/artifact/out/Dockerfile
GITHUB PR #6600
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname Linux fda160309c15 5.15.0-94-generic #104-Ubuntu SMP Tue Jan 9 15:25:40 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision HDFS-17384 / 1c72a0e
Default Java Private Build-1.8.0_392-8u392-ga-1~20.04-b08
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_392-8u392-ga-1~20.04-b08
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6600/2/testReport/
Max. process+thread count 4448 (vs. ulimit of 5500)
modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6600/2/console
versions git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@ferhui
Copy link
Contributor

ferhui commented Mar 6, 2024

Failed cases are unrelated.

@ferhui ferhui merged commit 8a97eae into apache:HDFS-17384 Mar 6, 2024
@ferhui
Copy link
Contributor

ferhui commented Mar 6, 2024

Thanks for the patch. Merged.

ZanderXu added a commit to ZanderXu/hadoop that referenced this pull request Mar 25, 2024
@ZanderXu
HDFS-17405. [FGL] Using different metric name to trace performance fo…
edb34ca 
…r FGL and Global lock (apache#6600)
ZanderXu added a commit that referenced this pull request Mar 25, 2024
@ZanderXu
HDFS-17405. [FGL] Using different metric name to trace performance fo…
794b5aa 
…r FGL and Global lock (#6600)
ZanderXu added a commit that referenced this pull request Apr 23, 2024
@ZanderXu
HDFS-17405. [FGL] Using different metric name to trace performance fo…
f733d94 
…r FGL and Global lock (#6600)
ZanderXu added a commit that referenced this pull request Dec 18, 2024
@ZanderXu
HDFS-17405. [FGL] Using different metric name to trace performance fo…
58dce1d 
…r FGL and Global lock (#6600)
ZanderXu added a commit that referenced this pull request Jan 7, 2025
@ZanderXu
HDFS-17405. [FGL] Using different metric name to trace performance fo…
5f1b041 
…r FGL and Global lock (#6600)
ZanderXu added a commit that referenced this pull request Jan 22, 2025
@ZanderXu
HDFS-17405. [FGL] Using different metric name to trace performance fo…
3bfc70b 
…r FGL and Global lock (#6600)
ZanderXu added a commit that referenced this pull request Jan 23, 2025
@ZanderXu
HDFS-17405. [FGL] Using different metric name to trace performance fo…
f0368bb 
…r FGL and Global lock (#6600)
YanivKunda pushed a commit to YanivKunda/hadoop that referenced this pull request Mar 23, 2025
@ZanderXu
HDFS-17405. [FGL] Using different metric name to trace performance fo…
579cba5 
…r FGL and Global lock (apache#6600)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ferhui ferhui ferhui approved these changes

Assignees

No one assigned

Labels

HDFS trunk

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ZanderXu @xleoken @hadoop-yetus @ferhui